Better parser #102
Merged
Better parser #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
AlecAivazis
force-pushed
the
svelte-parser
branch
from
24218c7 to
9cc7c6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After struggling for a long time to get the svelte preprocessor infrastructure from #101 working, I decided to flesh out the custom parser to isolate only the top-level scripts for a document's
moduleandinstancescripts.@thormuller @georgecrawford @pixelmund - mind running your application with these changes and see if anything pops up? I tried to add tests for as many weird edge cases as I could but i'm sure I'm missing something.
it is available as version
0.7.2-rc.4which should be tagged with@nextfixes #100